Session variables is not removed from memory

[Dahlsvarehus.com]

NOTE: not sure this is done right or if there is other places in webid it has to be done,
this is part of comment to the will this script be completely rewritten from scratch?

Removed! the code as some actual thinking this example was a mod.

[interdummy]

Sorry, to clarify this issue -

$_SESSION['SELL_array'] means to put your SELL_action, SELL_payment etc into a single array like so:

$_SESSION['SELL_array'] = array(
'payment' => 'etc',
'action' => 'etc'
);

Then, you can simply unset them all by unsetting the entire array. This also allows you to better manage the entire data for an auction, serialize that data between requests, and easily store it for later. It is better practice.

Not just that, because when you delete you use $_SESSION['blah'] = ''; you're control structures are messy. It should be:

if(isset($_SESSION['SELL_array']['action']))

not:

if(!empty($_SESSION['SELL_action']))

You can also move all this into objects and make it even more manageable.

With a well designed object, this could turn into:

$auction->loadData($_SESSION['SELL_array']);

if($auction->getPayment())

This then gives you the opportunity to reuse entire blocks of code, and will only make it more easier on yourselves, the developers, to further expand the script.

[pani100]

Hi Dahlsvarehus.com,
If you look closely it is not unsetting anything apart from the first line unset($_SESSION['UPLOADED_PICTURES_SIZE']);
All the rest are actually setting the variables, preparing them for future use.

[interdummy]

Hi Dahlsvarehus.com,
If you look closely it is not unsetting anything apart from the first line unset($_SESSION['UPLOADED_PICTURES_SIZE']);
All the rest are actually setting the variables, preparing them for future use.

There is no need to prepare them for future use. Regardless of whether you prepare or not, storing each variable in a separate session variable is a waste when they can all be contained within a single array.

[carls1976]

so if im understanding you correctly you are saying replace all that with this

$_SESSION['SELL_array'] = array(
'payment' => '',
'action' => '',
'starts' => '',
'UPLOADED_PICTURES' => array(),
'with_reserve' =>'',
'reserve_price' =>'',
'minimum_bid' => '',
'file_uploaded' => '',
'title'=> '',
'subtitle' => '',
'description' => '',
'pict_url' => '',
'pict_url_temp' => '',
'atype' => '',
'iquantity' =>'',
'with_buy_now' => '',
'buy_now_price' => '',
'duration' => '',
'relist' => '',
'increments' => '',
'customincrement' => 0,
'shipping' => '',
'shipping_terms' => '',
'payment' => '',
'international' => '',
'buy_now_only' => '',
'action' => '',
'shipping_cost' => 0,
'is_bold' => 'n',
'is_highlighted' => 'n',
'is_featured' => 'n',
'start_now' => '1'
); 

[Dahlsvarehus.com]

NO i would not use this code.

[carls1976]

you mind explaining your reply a bit

[nay27uk]

you mind explaining your reply a bit

what he is saying is that in order to use that code you would also have to rewrite the rest of webid. Read the original thread he referes to in in greay text above

[carls1976]

maybe im missing something but from what i can see is all you are doing is using a array to store all the session variables instead of having loads of seperate sessions why would this mean you would have to rewrite the whole script

[nay27uk]

Dont know mate but thats what the bloke that made the original post said needs doing.
I supose if your confident enough that you could use it then why not use it, think dahl was refering to himself and folk like me that dont know how to code.