re: 1.2.2 Released

Discussion in 'General Support' started by renlok, Mar 24, 2017.

  1. renlok

    renlok Administrator Staff Member

    Joined:
    Oct 20, 2008
    Messages:
    2,858
    Likes Received:
    330
    BabyDunk likes this.
  2. BabyDunk

    BabyDunk Active Member

    Joined:
    Feb 26, 2017
    Messages:
    279
    Likes Received:
    22
    i'm just now realising i have a lot of edits to the core files and didnt keep track lol i will be getting my site live by Christmas at this rate :mad: lmao but thanks for all the hard work ;)
     
  3. renlok

    renlok Administrator Staff Member

    Joined:
    Oct 20, 2008
    Messages:
    2,858
    Likes Received:
    330
    you can se something like http://winmerge.org/?lang=en to see which files you have changed
     
  4. BabyDunk

    BabyDunk Active Member

    Joined:
    Feb 26, 2017
    Messages:
    279
    Likes Received:
    22
    Last edited: Mar 24, 2017
  5. BabyDunk

    BabyDunk Active Member

    Joined:
    Feb 26, 2017
    Messages:
    279
    Likes Received:
    22
    @renlok that's called using your head, your feets for dancing lmao i would have just went through the files one by one . thanks for that. i think you may have just saved me some time lol :D ;)
     
  6. renlok

    renlok Administrator Staff Member

    Joined:
    Oct 20, 2008
    Messages:
    2,858
    Likes Received:
    330
    BabyDunk likes this.
  7. david62311

    david62311 Well-Known Member

    Joined:
    Aug 29, 2013
    Messages:
    2,125
    Likes Received:
    237
    Ha...I didn't even know you posted this but, was bored and installed the Github zip just a couple of hours ago and was surprised I can see a home page when I loaded it. I was just going to message you @renlok to let you know it was working on my end but, I thought I better first see if you posted there was a new version out. Now I see this post here.

    Can you remove the tmail.com in the email blacklist please so, it doesn't get installed on a fresh install? It was mentioning I was blacklisted when I tried to sign up a user using a hotmail.com account. I first removed everything from the list to make sure it was a filter blocking me. I was able to register when I did that. Then I went through the whole list eliminating each section at a time until I found out what the culprit was when I hit the t's and then had a closer look at what was there.

    Were you trying to make it so it would show the sitename as the sender in some of your latest updates? It's still showing the admin's email as the sender or what email we are choosing to use as our default email to send from. I will take a closer look at that. I couldn't do this in the last Webid script but, the prior one I could. I can set up my email to send like this now and this is just an example and it will show the sender as Webid now: Webid <admin@webid.com>

    It's good to see the latest Github is working and I can see my home page. Thanks for the hard work in getting that working! I will run further tests report any bugs bugs I find or and submit proposals if I can fix them.
     
  8. BabyDunk

    BabyDunk Active Member

    Joined:
    Feb 26, 2017
    Messages:
    279
    Likes Received:
    22
    @david62311 i was hoping to use site name as sender also, i did try to get it to work on 1.2.1 but with my limited knowledge i just was able to pull it off. i how this will be added in the next version :D

    Thanks again ;)
     
  9. nay27uk

    nay27uk Super Moderator Staff Member

    Joined:
    Nov 24, 2009
    Messages:
    5,572
    Likes Received:
    546
    Lads I already fixed the sender email problem to use the site name instead of the admin email as well fixing the rather long and unnecessary email titles/subjects a few weeks ago.

    It is in a thread in the general support somewhere.

    I even posted a link to the thread in the bug tracker for it to be fixed in the next version but it has obviously not been looked at or fixed in this version and still remains un assigned in the bug tracker.

    FIX IS HERE

    And the Bug Tracker Post.
    HERE
     
    Last edited: Mar 25, 2017
    BabyDunk likes this.
  10. david62311

    david62311 Well-Known Member

    Joined:
    Aug 29, 2013
    Messages:
    2,125
    Likes Received:
    237
    I just installed the latest Webid from Github about 14 hours ago and what I received in my hotmail.com inbox was showing the sender as the email address. Maybe it's different for different email services but, the email address was showing as my sender in my hotmail.com inbox.

    I had seen some work was done there but, I thought I saw Renlok did something within the past day or so. Actually here it is. https://github.com/renlok/WeBid/commit/0f9e5b1804472e9b863c637982ff945162953929 The one change I see there in the includes/class_email_handler.php . Maybe something has changed since you fixed it.

    I really never have a lot of time to spend helping out much anymore but, I will check it out closer when I have some time...tick tick tick tick tick...okay...I had some time and took a look at it. It hadn't been updated on Github.

    On line 48 from:
    PHP:
    $headers[] = 'Sender: <' $system->SETTINGS['adminmail'] . '>';
    To:
    PHP:
    $headers[] = 'Sender: <' $system->SETTINGS['sitename'] . '>';
    I have sent in a proposal after I tested it. It seems to work.
     
    BabyDunk likes this.
  11. nay27uk

    nay27uk Super Moderator Staff Member

    Joined:
    Nov 24, 2009
    Messages:
    5,572
    Likes Received:
    546
    Yep same as my fix
     
  12. BabyDunk

    BabyDunk Active Member

    Joined:
    Feb 26, 2017
    Messages:
    279
    Likes Received:
    22
    when i was having a look at it, i thought i needed to have the email address and the sitename all on the one line, any bit of wonder i couldn't get it working lol thanks people :D @nay27uk and @david62311 ;)
     
  13. BabyDunk

    BabyDunk Active Member

    Joined:
    Feb 26, 2017
    Messages:
    279
    Likes Received:
    22
    Error after update

    the piece of code flagged
    PHP:
    function FormatDate($DATE$spacer '/'$GMT true)
    {
        global 
    $system;

        if (!
    $GMT)
        {
            
    $DATE += $system->tdiff;
        }

        if (
    $system->SETTINGS['datesformat'] == 'USA')
        {
            
    $F_date date('m' $spacer 'd' $spacer 'Y'$DATE);
        }
        else
        {
            
    $F_date date('d' $spacer 'm' $spacer 'Y'$DATE);
        }
        return 
    $F_date;
    }
     

    Attached Files:

  14. BabyDunk

    BabyDunk Active Member

    Joined:
    Feb 26, 2017
    Messages:
    279
    Likes Received:
    22
    Ooooo i see whats happened the files have completely overwritten, must restart again :D
     
  15. BabyDunk

    BabyDunk Active Member

    Joined:
    Feb 26, 2017
    Messages:
    279
    Likes Received:
    22
    I'm all over the place here lol

    turns out i do i have a problem on the home page

    date.php
    PHP:
     // convert datetime from UTC to users timezone
        
    public function printDateTz($datetime$UTC_input true)
        {
            if (
    $UTC_input) {
                
    $UTC_time = new DateTime($datetime$this->UTCtimezone); <---line45
                $UTC_time
    ->setTimezone($this->timezone);
                return 
    $UTC_time->format('Y-m-d H:i');
            } else {
                
    $tmp = new DateTime($datetime$this->timezone);
                return 
    $tmp->format('Y-m-d H:i');
            }
        }
    index.php
    PHP:
    // get last created auctions
    $query "SELECT id, title, starts from " $DBPrefix "auctions
                WHERE closed = 0 AND suspended = 0
                AND starts <= CURRENT_TIMESTAMP
                ORDER BY starts DESC
                LIMIT :limit"
    ;
    $params = array();
    $params[] = array(':limit'$system->SETTINGS['lastitemsnumber'], 'int');
    $db->query($query$params);

    $i 0;
    while (
    $row $db->fetch()) {
        
    $template->assign_block_vars('auc_last', array(
                
    'BGCOLOUR' => (!($i 2)) ? '' 'class="alt-row"',
                
    'DATE' => $dt->printDateTz($row['starts']), <--- line129
                
    'ID' => $row['id'],
                
    'TITLE' => htmlspecialchars($row['title'])
                ));
        
    $i++;
    }
     
    Last edited: Mar 26, 2017
  16. david62311

    david62311 Well-Known Member

    Joined:
    Aug 29, 2013
    Messages:
    2,125
    Likes Received:
    237
    Yes you are all over the place. You're showing us issues from an older version. This thread is for the latest version that just got released on Friday.
     
  17. BabyDunk

    BabyDunk Active Member

    Joined:
    Feb 26, 2017
    Messages:
    279
    Likes Received:
    22
    Hi @david62311
    i am getting these errors from the version i downloaded in this thread,
    i have repeated the update process many times checking to see if i have made a mistake with the update process, on post 13 i forgot to chown the web dir before running the /install/update.php but i have since restored my backup and run through the process making sure to chown dir before running the update script. but every time i try to view a page that has listings(whether its home page,listing page, any pages with listing inside the admin panel) i get the error on post13 concerning the date .

    i have tried a fresh install but i cant get passed setting the admin password and username page but the home page does display on a fresh install
     
  18. nay27uk

    nay27uk Super Moderator Staff Member

    Joined:
    Nov 24, 2009
    Messages:
    5,572
    Likes Received:
    546
    check the items in the database and make sure the start dates have no miraculously gained back an old WeBid problem where the start dates become 1970
     
  19. nay27uk

    nay27uk Super Moderator Staff Member

    Joined:
    Nov 24, 2009
    Messages:
    5,572
    Likes Received:
    546
    you will have to copy the unix date from the database and use an online unix to time/date converter LIKE THIS to see what is stored in the database
     
  20. BabyDunk

    BabyDunk Active Member

    Joined:
    Feb 26, 2017
    Messages:
    279
    Likes Received:
    22
    i just re-download the version found in this thread and i get the same errors
     

    Attached Files:

Share This Page