1.2.2.2 Github version Testing

Discussion in 'Install/Upgrade Support' started by pani100, Jul 29, 2017.

  1. pani100

    pani100 Well-Known Member

    Joined:
    May 9, 2011
    Messages:
    2,327
    Likes Received:
    449
    Wondering if anybody has been running or testing the github version of webid at all.
    Would be good to get any problems found sorted one by one.
     
  2. BabyDunk

    BabyDunk Active Member

    Joined:
    Feb 26, 2017
    Messages:
    279
    Likes Received:
    22
    Yes i am running with the github version @pani100 updating github when i come across a problem. i see you have been doing a bit yourself today. thought you were going to be taking it easy for awhile lol (you're hear that to often now)

    i see a problem with sending emails to hotmail. they always get marked as spam . The Dkim was failing an i was able to get that changed to pass by changing the way the buildmessage function worked in class_email_handler.php. With Hotmail if there is to much whitespace the dkim verification fails.

    replaced this
    PHP:
    eval("\$this->message = '$template_php';");
    with this
    PHP:
    $htmlMsg '';
            
    $myHTML $template_php;
            
    $myHTML preg_replace('/\s+/'' '$myHTML);
            
    $lines explode("\n"$myHTML);
            foreach (
    $lines as $line$htmlMsg .= trim($line)."\n";
          

            eval(
    "\$this->message = '$htmlMsg';");
    but i am still getting a dkim=temperror on the the second part

    check my header
    Code:
    Received: from VE1EUR01HT190.eop-EUR01.prod.protection.outlook.com
    (2603:10a6:207:8::28) by AM3PR06MB1139.eurprd06.prod.outlook.com with HTTPS
    via AM3PR07CA0142.EURPRD07.PROD.OUTLOOK.COM; Sat, 29 Jul 2017 17:14:58 +0000
    Received: from VE1EUR01FT039.eop-EUR01.prod.protection.outlook.com
    (10.152.2.52) by VE1EUR01HT190.eop-EUR01.prod.protection.outlook.com
    (10.152.3.229) with Microsoft SMTP Server (version=TLS1_2,
    cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.1240.9; Sat, 29
    Jul 2017 17:14:58 +0000
    Authentication-Results: spf=pass (sender IP is XX.XX.XX.208)
    smtp.mailfrom=example.com; hotmail.com; dkim=pass (signature was
    verified) header.d=example.com;hotmail.com; dmarc=pass action=none
    header.from=example.com;
    Received-SPF: Pass (protection.outlook.com: domain of example.com
    designates XX.XX.XX.208 as permitted sender)
    receiver=protection.outlook.com; client-ip=XX.XX.XX.208; helo=
    server1.example.com;
    Received: from SNT004-MC4F13.hotmail.com (10.152.2.51) by
    VE1EUR01FT039.mail.protection.outlook.com (10.152.3.35) with Microsoft SMTP
    Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id
    15.1.1240.9 via Frontend Transport; Sat, 29 Jul 2017 17:14:57 +0000
    X-IncomingTopHeaderMarker: OriginalChecksum:F8890873EA1449278AD7AE1817E1024AE0AE6EAC04EF97A1F7BB38CF4E34D3A7;UpperCasedChecksum:1A62E6291A828C1C5DC430949D7141D70B354D6D258A3F849BC90BB9ECF5B860;SizeAsReceived:2575;Count:19
    Received: from server1.example.com ([XX.XX.XX.208]) by SNT004-MC4F13.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23143);
        Sat, 29 Jul 2017 10:14:55 -0700
    Received: from localhost (localhost.localdomain [127.0.0.1])
       by server1.example.com (Postfix) with ESMTP id 8C5933C8238F
       for <example@hotmail.com>; Sat, 29 Jul 2017 18:16:03 +0100 (BST)
    DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=example.com;
        h=content-transfer-encoding:content-type:content-type
       :mime-version:x-mailer:message-id:reply-to:from:from:date:date
       :subject:subject; s=fs200720172118; t=1501348562; x=1503162963;
        bh=9q2pZZXquJRCksFO6YKuNOn6She1VTQsAskH4qeQWoA=; b=CdscjcmlJnun
       Ml2EmYD1rPjISPY0NC9Pusb/WIpNqAKh1YrNRwkNvyg9U/1DtqR26P5PNmqrwRfc
       ywetwGz/1HS1GS8SqhA8rHXd1eTsqphwvdBKO0AbVJvcTub6+ivOHa7r7lQXjgHi
       3VTZ0YT6J0nG+IYIgEHQtuMCcuURgqu+N07sKeVmWe9FBlZq0TtmqJlgi6OOAq5d
       4AbuxqaYQwfwUffpQuivmFQ8IzmdDqifPzYz4wGFo0q6MDmFUcXWd/w15Kn+mrYm
       BRtCdudreb2vfwqmlREZ+2pXWK36HlWpaQ8mfX4/ulcupWIIm4VpFDceMs7jdzCV
       U8Kc8yvM8Ia/yUhaUcREAlHOaOBesMLV1u4g2EUy3q3MgtEBXVa1toGSmJCAOB4Y
       0pWNISqj0u/iel21eUnJk2egwGFm/t4xisgUKY6N5enVfPoljkHt8Ac2np+qnLXY
       HMwo2f/vtOWHk1kdd10BO+QwfNZNZ/0jXbjGb30I+ATpLwzIG2Ngdcto9IaGv1Ws
       R5zUnprm5VoHE/cdtKX2gPgVdfjAbebjmIyb3hmznLwsY7rOfMwmhZkBzyUR3bOo
       jCdeJpcCdJ4jbnYvkc9gOEEcnsSF0OEwI5dbGAtIOgvGvSWwcLtes6uJ2ye9kHfH
       3AjcWf9ZDexFdqDCUBmxkCgSf3k4Qa0=
    X-Virus-Scanned: Debian amavisd-new at server1.example.com
    Received: from server1.example.com ([127.0.0.1])
       by localhost (server1.example.com [127.0.0.1]) (amavisd-new, port 10024)
       with ESMTP id Z2G-GSJNUOCD for <example@hotmail.com>;
       Sat, 29 Jul 2017 18:16:02 +0100 (BST)
    Received: by server1.example.com (Postfix, from userid 5010)
       id 015423C82398; Sat, 29 Jul 2017 18:16:01 +0100 (BST)
    To: <example@hotmail.com>
    Subject: example.com - New Auction Notifications
    X-PHP-Originating-Script: 5010:class.phpmailer.php
    Date: Sat, 29 Jul 2017 17:16:01 +0000
    From: "example.com - " <postmaster@example.com>
    Reply-To: "postmaster@example.com" <postmaster@example.com>
    Message-ID: <192ca94909585726a73a1e527f6c89c0@example.com>
    X-Mailer: PHPMailer 5.2.16 (https://github.com/PHPMailer/PHPMailer)
    Content-Type: multipart/alternative;
       boundary="b1_192ca94909585726a73a1e527f6c89c0"
    Content-Transfer-Encoding: quoted-printable
    Return-Path: postmaster@example.com
    X-OriginalArrivalTime: 29 Jul 2017 17:14:55.0403 (UTC) FILETIME=[32C50FB0:01D3088E]
    X-IncomingHeaderCount: 19
    X-MS-Exchange-Organization-Network-Message-Id: 557ca21e-f803-4412-8f5d-08d4d6a556b9
    X-EOPAttributedMessage: 0
    X-EOPTenantAttributedMessage: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa:0
    X-MS-Exchange-Organization-MessageDirectionality: Incoming
    CMM-sender-ip: XX.XX.XX.208
    CMM-sending-ip: XX.XX.XX.208
    CMM-Authentication-Results: hotmail.com; spf=pass (sender IP is
    XX.XX.XX.208; identity alignment result is pass and alignment mode is
    relaxed) smtp.mailfrom=postmaster@example.com; dkim=temperror (identity
    alignment result is pass and alignment mode is relaxed)
    header.d=example.com; x-hmca=pass header.id=postmaster@example.com
    CMM-X-SID-PRA: postmaster@example.com
    CMM-X-AUTH-Result: PASS
    CMM-X-SID-Result: PASS
    CMM-X-Message-Status: n:n
    CMM-X-Message-Delivery: Vj0xLjE7dXM9MDtsPTA7YT0wO0Q9MjtHRD0yO1NDTD02
    CMM-X-Message-Info: 11chDOWqoTkZHEbnXUuz/yglqQe+tPovoYwHLRqoH7kvlzM9TvgfHfCL5xvNywn0XaGf8GtkDqi+9YVYRlAfkFQyaCgFOr24vz//gcaG/FeIXiznrK//3phcCE96R05lBm6V0aW4vXugqWrUzBGB7g8UPY5QItMQJInrAbjRyfRdxmUO+wiJBF39yRovFjoddM8bAqB7MmWEVQrfssP1QQyglDReKrR1UWq/pCcXtlwvsUT1pMg2fQ==
    X-MS-Exchange-Organization-SCL: 5
    X-MS-Exchange-Organization-PCL: 2
    X-Microsoft-Exchange-Diagnostics: 1;VE1EUR01FT039;1:DDIb8UKTg4GGHpR05z7xcTeuEHXsgICc60q1aWjRC7JTo3/Mkui0kCfdAozGg/c5D5LaKc13Z+T+I8nKCHGJX8JWh63tAFJoLkW2IAgLZohMfm+OsPHW8TMee9Xh9TW0i+Bl9pBDw+FYi7iabYCRwFbB1XsgWLo25d+lBHAN4NJrq5RoO6zMrXvZ7JxNQ8mqL8cmtIqgxozYFVkyCjDk48B7Q0S1Lod8aRk5wbAuQE6qp0SYtBkUtDcK9zmqhNhT+yS2nkjWxvo+ThCn7DnR2rFE/NMTKAdq6BQBrJwOlIN/JG9/JwBQmumDqE4WG5F5WlkQFOHFxerp2k6V7T3RW2ZPdRW8dNVBe42KwTBmnDNBeiFak8jZWOJfOWnholzGAEorL5+tCQHLbzLr5bU06StkvbFxH1a9sKiR0oJjGsrgYP+DG+LE202iOZt00KpcIAu9GAH2SVhV2oldJge4H/QTDbDjdsg9USHXo1aw5OMSIo/gLPi8BQFXAZDaoIPU
    X-Forefront-Antispam-Report: EFV:NLI;SFV:SPM;SFS:(28900001);DIR:INB;SFP:;SCL:5;SRVR:VE1EUR01HT190;H:SNT004-MC4F13.hotmail.com;FPR:;SPF:None;LANG:en;
    X-MS-Exchange-Organization-AuthSource: VE1EUR01FT039.eop-EUR01.prod.protection.outlook.com
    X-MS-Exchange-Organization-AuthAs: Anonymous
    X-MS-PublicTrafficType: Email
    X-MS-Office365-Filtering-Correlation-Id: 557ca21e-f803-4412-8f5d-08d4d6a556b9
    X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(23075)(8291501071);SRVR:VE1EUR01HT190;
    X-Microsoft-Exchange-Diagnostics: 1;VE1EUR01HT190;3:qxinLdUj6PbE9Fk80ChlKGXBsNJaTzXKS5pcqpMclrQWKNcSssBy/53np/HS13xSp4aNi8V/5vVpw11n5JRggavQ0FsH7Qb3znD8GPsddo04VzfEuTTNWupern6zogbbteTq7NUAua6SFmRz3RfqarRn5+Fqv0SLuzM5IHVmds+JS9i1tJCIJKDONmGJ2RlxvCLpI9fIXnWbn4EzCe4mBSa/D+BKs0VNvL9EX8bhXiwrfPQZClxg+boswrlCaBlYGwlz5CeMxjylG7UGPH1sAxcRLU195+9M2MJEvDE74+c4gZHlI8CbWaZFBfRk1pHuzcI1CnaArKTpMmgvKlh63jif+3LeqmfcMHhd567IdoWhRV2sXcQKb0YZqZf3Mbe6pOyoPZ/irIPc35JUdM25M6XEaRDzSMj3gGA/W9rPG8ZmC2V4mMjtd5H/SekXJzd2QJYeei56ptc1Vpb3LICchIfA0wLKqlwAxeV3l26VkwAYA5LYcIaNHezIaqlvl7DXinCXFuENRwNdxLGpXFLCDW7u3WXC5WADDSmT9k/sGyE=
    X-MS-TrafficTypeDiagnostic: VE1EUR01HT190:
    X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;VE1EUR01HT190;25:pos0aANRgkZ69Ib/ZO0+hfzBVj+NSaAmjsaXNCf8m?=
    =?us-ascii?Q?bdo7+MxC66ugXGJ2t4tSgep/mY6mjgjydU3AwbyaKR9dh6UL7pnEjm699PwL?=
    =?us-ascii?Q?4FdFVSdcKIAnJ81913oXcyArkW7la/nougO8e0+q1WTd3oH6um6vtmjQW+Kk?=
    =?us-ascii?Q?bjIRG7Zs0MCZHK6n75WqkdQq4OkZ1/3zZu0iSCsT8XTOTYOhIWCZgrDjYUjc?=
    =?us-ascii?Q?k5bjlAuEw9bGgXT0A265bMjDsZHJIvzweMtaewrcOqrzE+nCWX0IJ2fMwqHx?=
    =?us-ascii?Q?97m0skv8YXgn1Ehs3cH3kOSFqbcj7MDssrZLRDT8ewUK03QerqFIH29qQtgn?=
    =?us-ascii?Q?LVAyREhnGOveLtTU4HD0AFZcJVUlIJjnrIl2wdd4W5fj17wFT00dOHQNhs1x?=
    =?us-ascii?Q?FunIY+VKEAx+gV6WmHdue92BQP/Z1XmiXfRH7fKMRG6bn0HuLpbNSf5USEkm?=
    =?us-ascii?Q?1y6kiZQcLZez/bXn4dIXhjb9LY7TjDXpE5ipRXC5ncDARLoyL1DcDEv83hrF?=
    =?us-ascii?Q?TKiRpgoNOqaXVitGhE3FinIJdms2fd9/Ie7bXQUDZ8YUXcwICIXud9RwK5b/?=
    =?us-ascii?Q?9QLJ/ZVu0K5XeVXtUg4hh400S+XIfyL+5Nbr/9Gj7NDH1uRN1qooT9fT7huT?=
    =?us-ascii?Q?qnruT3qw0JdZZS9qfHuk68lpG/UXD1oo1AcK1D3oRVv8VK06i5ijVWtIW2oH?=
    =?us-ascii?Q?86E4Dt5canYBIqJl3VuSBD5XuUkPCnhxlMTGkJa6Xb4hwLCX9EvgYaYbLaRD?=
    =?us-ascii?Q?UOCkGot7I8/NY/WPVq+GcykCpD69+KqBcOL890xn94tIrY9ZUqpzsf5fcnuV?=
    =?us-ascii?Q?CIxS4e6/lCckhwU+za+HxirDeBy14M3i28wLyrsX0Fvou/rF0lUAiho6d2Hx?=
    =?us-ascii?Q?JQrLXvpp19XsgGq7YdZgHEVIichhbz0GDhqTnTz//2abm0oM14K4DkWV4wRe?=
    =?us-ascii?Q?WtFnzg4xZ8QFNuHo2+33mQ2YVckUBudJeol15fFr0VGeGOyJBl6wL0SIMYWu?=
    =?us-ascii?Q?83lkGyJWQ5kA0yjCdEmAc/h28AC5EPV/vG/xhs4TZG+YA=3D=3D?=
    X-Microsoft-Exchange-Diagnostics: 1;VE1EUR01HT190;31:+r4uB4eBQ4xYEgj3lkwCgd/DkcpMTu5+4QhSvS44PvxbvaOamOr4GkIjRbwmTysn1cPwTjSA22201zSO6JI6jrvDK828+gohwY1Khq4dvlh3Z9TWCM4TdMTHBso2MtwaypVvZESkoH6dRuiRlE6vAIkYTltXnoq024G02WwFnxRp7rfomhTey8tk9AMzjV/XHfQRhXYEGDYTJlXh/PgAAtvZ8odDFBHQdWoJU52EhV3+iz2nanUSJ5qCWi1fyY3x6yU9CvkqA9Edg8BRmBVd9lEzfY0s+BnENemAHC1u3SLCZK5Ybf7Eds5Go5Qs4Y0ggOOgbH7UTcCQwLaarNPvdGMAu/Fjs2T9wDs/59bFSnUYQiVkm8HmkL0p8eRIXi91PPZ2G4RA9b3sPnPR3KJRrG2EK6+ps+4WiENAhGk8ZPyq7Oy8btmGUYZ+ThN/SfxoFe45lz5uMvIbmOu69ZUMsLZBLvRO3oV28/nOQJ1QkMOtM9imGCsR4KQcpJxRtx4mFLdxZlb6nMUEOSQprCp28IuCfhkYgDPqWwPPVJV8RtUgIs2JNEBjErw29YjPaOPLOaBq01p9JWiRus7l8IDNSxiwIIZWZ5dCnsx3QUWY1W1P35eNtCShXz5Cm6iGWSBvhXB5zfLd4hoPth2RL0jT7akssBjJIWUgjWA8371n2DGCHwGFiiHrvm0bdeM5sHK3FHwMq/yc3y70ErMDzI1pFd6S5PCchGzotl98oYwtA9A=
    X-Exchange-Antispam-Report-Test: UriScan:(148322886591682)(31418570063057)(211936372134217)(80641642340047)(86561027422486)(81227570615382)(64217206974132);
    X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(444000031);SRVR:VE1EUR01HT190;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:VE1EUR01HT190;
    X-Microsoft-Exchange-Diagnostics: 1;VE1EUR01HT190;4:XKRqjWa2QIIHS6F9ODTVPUVQd6/OtU6Kh4Af9otfGRHVaoPErWKHFWOyt/fNcX0o+GRkEGY+mPg5durP3kGqXD7KNXEVoVKAtH+H5+ndhWtuBgfBYQwnkjS4Ok9voXmjM+d10PNnMIxY2sdsX2O1uG7rYli6v2eaJ+LNtpIligKmRE6rZs98Drqyr9Bl0Y2S/qdXScNI7zZRnCTmK7aCa5eFgHA1IfoCAvXlwlB3egMTSR6sA6IU+OGpwpZgiSfbOtT4szheOKwNQVmPBAgsrZPbxx8bf4maqwcVhn3eI5hesjNTR3l12Sjty2hCnee9A/hFkqzT9Oz9ZC4urrODMavMLFjGQojXLv64TGuKDHRoSo2CXU/pwGMZSP9wRfI6I2KPjd7/yGFbB0FnVfnih0aZQOqN2j86yqvRoh7LUbLOC3n8D7Hf90Y+QxVwX3jRbd06QgggIHql6sRirEYFM/UzIZ5UCrstBx/3uo1Zp6yexFEOhoSCTAF32Rwnj12BRhRSMB0KlOKQox1jgaaVg4gJsljtEpxwMsMwDmsG7h7MT87gqkXO/0zXvagwohndFQyF4JCSTo79O8dTVXiPWKZqnmzxeCMpN/Sy7KYEALz4f8oMlV6PeKoU0i2Lk4ObXT8PAVUa/axpAWfzIsi68OLl2t8dPEDOwm54znbZsKFR+OqBEkRAhtHiHMm7iu77kpNMU/Im8TC4jrZBDEhweA==;23:nylIVuI+jJiQK02c0cGUZdKosipZqj604DlLrnKnh5ZxKYfLw3VR2ozJeQ0Me9P0aLgkUV60fC55xrap0mAc8W9Fk4Xe5V4lBXsrtU30AqDtzM4jmHQZxCEIH6PP8+8RxcplYqJRd5uVANjm/a2+F4RaWE+6TesC6ltJOqaccQy9zZ/QSHRiprNUeT+InUVLkDrOHHK25oscS+23dyjdbw
    ==
    
    Hotmail is always a pain when sending mail to.
     
  3. pani100

    pani100 Well-Known Member

    Joined:
    May 9, 2011
    Messages:
    2,327
    Likes Received:
    449
    So you are using smtp?
    I did a few commits which renlok has just received and added, in them was an update to the PHPMailer classes and a few admin additions so now when you select and save an email protocol when you do a test email any errors (on preparing and sending) might be flagged up.
    Try adding these changes in and give it a try
     
  4. BabyDunk

    BabyDunk Active Member

    Joined:
    Feb 26, 2017
    Messages:
    279
    Likes Received:
    22
    I am indeed using smtp.

    i will try and get your commit added to mine some point tomorrow. i have already added the latest PHPMailer update. even tried the 6 version but it needed a bit more work than i had time for.
     
  5. BabyDunk

    BabyDunk Active Member

    Joined:
    Feb 26, 2017
    Messages:
    279
    Likes Received:
    22
    @pani100 i am having trouble with your update to includes/class_email_handler.php. no mail gets sent at all but sends fine when i place the former version. i don't get any errors, i just don't receive any mail.

    its a bit late to look into further for me but will try tomorrow :D
     
  6. pani100

    pani100 Well-Known Member

    Joined:
    May 9, 2011
    Messages:
    2,327
    Likes Received:
    449
    @BabyDunk are you using ssl or tls? I have tried a few times using tls but it seems to freeze the server.
    You can debug the smtp. In class_emailhandler.php line 378
    PHP:
    $mail->SMTPDebug 0;
    you could change to 1 (goes up to 4).
    SMTP::DEBUG_OFF (0): Disable debugging (you can also leave this out completely, 0 is the default).
    SMTP::DEBUG_CLIENT (1): Output messages sent by the client.
    SMTP::DEBUG_SERVER (2): as 1, plus responses received from the server (this is the most useful setting).
    SMTP::DEBUG_CONNECTION (3): as 2, plus more information about the initial connection.
    SMTP::DEBUG_LOWLEVEL (4): as 3, plus even lower-level information, very verbose, don't use for debugging SMTP, only low-level problems.
    Then when you do a test email in the admin-> email settings, view the response in the console. It will echo the debugging information in the response.
     
  7. BabyDunk

    BabyDunk Active Member

    Joined:
    Feb 26, 2017
    Messages:
    279
    Likes Received:
    22
    strike my last post :oops: it was my bad . i didnt have my smtp server settings set correctly. i also must have commented out isSMTP() away back when i first started using webid 6months go. all is working as it should although i still get a dkim=temperror in the second verification with hotmail

    i am using ssl on port 465.

    and yes thank you for updating the emailsettings.php . it definitely helped with rectifying my problem. the Debugging work a treat ;)
     
  8. pani100

    pani100 Well-Known Member

    Joined:
    May 9, 2011
    Messages:
    2,327
    Likes Received:
    449
  9. BabyDunk

    BabyDunk Active Member

    Joined:
    Feb 26, 2017
    Messages:
    279
    Likes Received:
    22
    yes i am using dkim. i like to try anything that will protect my rep and hopefully make sure my emails get passed through successfully and avoid the spam box.

    it was all presetup when i updated my ispconfig host panel. it works sweet with every other email provider but the dreaded hotmail . they always seem to find some problem to send mail to junk box but i must say this is the closest i have got with webid to getting mail to the indox. spf pass and dkim pass but for some reason on CMM-Authentication-Results: i get dkimtemperror.

    i'll get a look at them links shortly and thanks ;)
     
  10. BabyDunk

    BabyDunk Active Member

    Joined:
    Feb 26, 2017
    Messages:
    279
    Likes Received:
    22
    Just tested tls security and i am having the same problem as you @pani100 server locks up and php needs restarted. i don't get any debugging info either
     
    Last edited: Jul 30, 2017
  11. pani100

    pani100 Well-Known Member

    Joined:
    May 9, 2011
    Messages:
    2,327
    Likes Received:
    449
    Yes, have to leave for a few minutes before it times out. Don't know why it is doing that. I am on a local server so don't know if that has anything to do with it.
     
  12. BabyDunk

    BabyDunk Active Member

    Joined:
    Feb 26, 2017
    Messages:
    279
    Likes Received:
    22
    mines is a dedicated and it does the same. i have a number of other sites on it with no bother. must be a code problem but i dont have much time to look at it today and as long as one option works for me im happy at least for the mean time :rolleyes:
     
  13. pani100

    pani100 Well-Known Member

    Joined:
    May 9, 2011
    Messages:
    2,327
    Likes Received:
    449
    I will leave it for now and maybe get back to this at some point.
    Any other issues you have found? I am concentrating on the admin side first, getting the admin working error free and then I will move on to the front end, so I have not tested that side thoroughly yet.
     
  14. BabyDunk

    BabyDunk Active Member

    Joined:
    Feb 26, 2017
    Messages:
    279
    Likes Received:
    22
    i think the maintenance mode should be allowed to have more that one test account. i did look into this but couldn't get it to loop through all the explode'd user list. for some reason (Which i'm sure i will figure out at some point) it would only allow one account at a time to be active. this is all a learn curve for me but it learn a lil bit more every time :)
     
  15. pani100

    pani100 Well-Known Member

    Joined:
    May 9, 2011
    Messages:
    2,327
    Likes Received:
    449
    @BabyDunk , I am sure we could make it work on an expanded list.
    I think when an admin is logged in they should have the complete run of the front-end when in maintenance mode (using the same browser). This should be easier as the admin sessions do exist and get passed on to the front-end.
     
  16. pani100

    pani100 Well-Known Member

    Joined:
    May 9, 2011
    Messages:
    2,327
    Likes Received:
    449
    And here you go:
    When admin is logged in and maintenance is on we can do the following to test our front-end without having to login as a selected user:
    In functions_global.php find around line 186
    PHP:
    if ($user->logged_in && ($user->user_data['nick'] == $this->SETTINGS['superuser'] || $user->user_data['id'] == $this->SETTINGS['superuser'])) {
                    return 
    false;
                }
    and replace with:
    PHP:
    if ($user->logged_in && ($user->user_data['nick'] == $this->SETTINGS['superuser'] || $user->user_data['id'] == $this->SETTINGS['superuser'])) {
                    return 
    false;
                }
                if (isset(
    $_SESSION['WEBID_ADMIN_IN']) && $_SESSION['WEBID_ADMIN_IN'] == 1) {
                    return 
    false;
                }
                return 
    true;
    Don't need no user or list of users to be registered in the maintenance tab. As long as you are logged into the admin side the front-end is accessable. This can work on multiple browsers too as long as an admin has logged in on each browser.
     
    Last edited: Aug 3, 2017
  17. BabyDunk

    BabyDunk Active Member

    Joined:
    Feb 26, 2017
    Messages:
    279
    Likes Received:
    22
    @pani100 Brilliant :D i will have to test this. will it be possible to register a user for maintenance access and the admin. so test listings can be bid against and any other usage that needs the access. just gets abit annoying login on with test users to load a listing an then having to change to another test user to test all the functions of the listing and vice versa..
     
  18. BabyDunk

    BabyDunk Active Member

    Joined:
    Feb 26, 2017
    Messages:
    279
    Likes Received:
    22
    that will only work if admin id is equal to 1. would greater than or equal 1 not be better. There wouldn't be any false positives with that would there??
    PHP:
    if ($user->logged_in && ($user->user_data['nick'] == $this->SETTINGS['superuser'] || $user->user_data['id'] == $this->SETTINGS['superuser'])) {
                    return 
    false;
                }
                if (isset(
    $_SESSION['WEBID_ADMIN_IN']) && $_SESSION['WEBID_ADMIN_IN'] >= 1) {
                    return 
    false;
                }
                return 
    true;
     
  19. BabyDunk

    BabyDunk Active Member

    Joined:
    Feb 26, 2017
    Messages:
    279
    Likes Received:
    22
    i get an indexing warning for WEBID_ADMIN_IN when admin isn't logged in.

    heres the fix.
    PHP:
    if ($user->logged_in && ($user->user_data['nick'] == $this->SETTINGS['superuser'] || $user->user_data['id'] == $this->SETTINGS['superuser'])) {
                    return 
    false;
                }
                
    $ADMINISLOGGEDIN array_key_exists('WEBID_ADMIN_IN'$_SESSION) ? $_SESSION['WEBID_ADMIN_IN'] : '';
                if (
    $ADMINISLOGGEDIN >= 1) {
                    return 
    false;
                }
                return 
    true;
     
  20. pani100

    pani100 Well-Known Member

    Joined:
    May 9, 2011
    Messages:
    2,327
    Likes Received:
    449
    @BabyDunk, not tried this yet but you could also try:
    PHP:
    if ($user->logged_in && ($user->user_data['nick'] == $this->SETTINGS['superuser'] || $user->user_data['id'] == $this->SETTINGS['superuser'])) {
                    return 
    false;
                }
                if (!empty(
    $_SESSION['WEBID_ADMIN_IN'])) {
                    return 
    false;
                }
                return 
    true;
     

Share This Page